Skip to content

Fix Docker image tag conflict in redis_combined_features target#43

Draft
Copilot wants to merge 10 commits into
masterfrom
copilot/combine-aof-and-rdb-tests
Draft

Fix Docker image tag conflict in redis_combined_features target#43
Copilot wants to merge 10 commits into
masterfrom
copilot/combine-aof-and-rdb-tests

Conversation

Copy link
Copy Markdown

Copilot AI commented Feb 15, 2026 •
edited
Loading

Problem

CI failed when running combined Redis tests: both AOF and RDB tests attempted to build images with identical tags (redis:test_net_13) but different IMAGE_TYPE build args, causing Docker to reject the second build.

ERROR: image "docker.io/library/redis:test_net_13": already exists

Changes

Makefile: Modified redis_combined_features target to use --tf.stop=true for the first (AOF) test instead of --tf.stop=false.

  • First test now removes containers/images after completion (--tf.stop=true) while preserving staging directory (--tf.clean=false)
  • Second test recreates network and builds fresh images with different IMAGE_TYPE
  • Staging directory reuse still provides time savings (avoids re-copying wal-g source, Go deps already installed)
# Before: --tf.stop=false caused image tag conflict
cd tests_func/ && REDIS_VERSION=$(REDIS_VERSION) IMAGE_TYPE=aof ... --tf.stop=false ...

# After: --tf.stop=true removes images, allows rebuild with new IMAGE_TYPE
cd tests_func/ && REDIS_VERSION=$(REDIS_VERSION) IMAGE_TYPE=aof ... --tf.stop=true ...
Original prompt

This section details on the original issue you should resolve

<issue_title>[FEATURE] combine aof and rdb test together</issue_title>
<issue_description>### What feature would you like?

prepation for redis testing takes time, I want both aof and rdb tests to run one after another in the same run

Why is this feature useful?

No response</issue_description>

Comments on the Issue (you are @copilot in this section)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

chipitsine and others added 2 commits February 15, 2026 14:35
@chipitsine
ci: pin govulncheck to the latest
fde0c2d 
it has issues with checkout fixed in current master
Initial plan
9a51c18
Copilot AI and others added 7 commits February 15, 2026 13:55
@chipitsine
Add redis_combined_features target to run AOF and RDB tests together
56ef623 
Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
@chipitsine
Add comment explaining redis_combined_features target
baaef71 
Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
@chipitsine
Fix: Keep Redis 6.2.4 as RDB-only test due to AOF format incompatibility
554525d 
Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
@chipitsine
Add error handling to ensure cleanup on AOF test failure
020ea68 
Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
@chipitsine
Simplify error handling by removing redundant directory change
bc3318a 
Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
@chipitsine
Fix cleanup command to run in correct directory
c697132 
Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
@chipitsine
Add clarifying comment for cleanup behavior on test failure
1c1b8e2 
Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
Copilot AI changed the title [WIP] Add feature to combine AOF and RDB tests Combine Redis AOF and RDB tests to eliminate redundant infrastructure setup Feb 15, 2026
Copilot AI requested a review from chipitsine February 15, 2026 14:04
Copilot AI changed the title Combine Redis AOF and RDB tests to eliminate redundant infrastructure setup Fix Docker image tag conflict in redis_combined_features target Feb 15, 2026
@chipitsine chipitsine force-pushed the copilot/combine-aof-and-rdb-tests branch from 5343c93 to aaccc5d Compare February 15, 2026 19:43
@chipitsine chipitsine force-pushed the master branch 2 times, most recently from 3633c51 to 81395bd Compare May 7, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chipitsine chipitsine Awaiting requested review from chipitsine

Assignees

@chipitsine chipitsine

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] combine aof and rdb test together

2 participants

@chipitsine